Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bytewords should follow alphabetically consistently #45

Closed
gorazdko opened this issue Oct 2, 2020 · 2 comments · Fixed by #46
Closed

bytewords should follow alphabetically consistently #45

gorazdko opened this issue Oct 2, 2020 · 2 comments · Fixed by #46

Comments

@gorazdko
Copy link
Contributor

gorazdko commented Oct 2, 2020

Abstract

In bcr-2020-012-bytewords.md most of the words look to be ordered alphabetically. The exception I ran into is
the last line:

0xf8: yoga yurt zaps zest zinc zone zoom zero

The same issue is in both (c and c++) implementations of bytewords.

This causes lots of difficulties on the UI side in lethekit.

@wolfmcnally
Copy link
Collaborator

I also found a second alphabetization error in the word list. I will have a fix for this out shortly, but it will be a breaking fix.

wolfmcnally added a commit to BlockchainCommons/URKit that referenced this issue Oct 5, 2020
wolfmcnally added a commit to wolfmcnally/bc-bytewords that referenced this issue Oct 5, 2020
**This is a breaking change.**

* Fix for [BlockchainCommons/Research#45 alphabetization error).
wolfmcnally added a commit to BlockchainCommons/URDemo that referenced this issue Oct 5, 2020
wolfmcnally added a commit to BlockchainCommons/bc-ur that referenced this issue Oct 5, 2020
* Fixed [ByteWords wordlist alphabetization error.](BlockchainCommons/Research#45)
wolfmcnally added a commit to BlockchainCommons/bc-ur that referenced this issue Oct 5, 2020
* Fixed [ByteWords wordlist alphabetization error](BlockchainCommons/Research#45).
wolfmcnally added a commit to wolfmcnally/seedtool-cli that referenced this issue Oct 5, 2020
…t alphabetization error.

* Updated to latest version of bc-ur, which fixes the [ByteWords wordlist alphabetization error](BlockchainCommons/Research#45). This was a breaking change, so all documentation and examples were updated.
wolfmcnally added a commit to wolfmcnally/bc-research that referenced this issue Oct 5, 2020
Updated all papers to fix [Bytewords wordlist alphabetization error.](BlockchainCommons#45)
@wolfmcnally
Copy link
Collaborator

Please see my commentary on the resolution of this issue here.

lightyear15 pushed a commit to lightyear15/bc-ur that referenced this issue Apr 12, 2023
* Fixed [ByteWords wordlist alphabetization error.](BlockchainCommons/Research#45)
lightyear15 pushed a commit to lightyear15/bc-ur that referenced this issue Apr 12, 2023
* Fixed [ByteWords wordlist alphabetization error](BlockchainCommons/Research#45).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants