Skip to content

Commit

Permalink
removed the todo, it is no longer to be done
Browse files Browse the repository at this point in the history
  • Loading branch information
matt-lough committed May 11, 2018
1 parent db31994 commit 8206d4a
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions blockchain/audit/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ The audit report focuses on the following key areas, although this list is not e
</tr>
</table>

### TODO ###

### Minor

- **Repeated checks can be replaced by modifier** - `Best practice`
Expand All @@ -100,7 +98,7 @@ The EthereumClaimsRegistry contract does technically implement all the features
## Observations

### Event log is beneficial to the observation of setting variables
When calling `setSigner()` with a new signer address, it is highly recommended that you emit an event to log the execution. This is not standard behavior, though it helps you track the history and lets you notice the variable has been changed.
When calling `setSigner()` with a new signer address, it is highly recommended that you emit an event to log the execution. This is not standard behavior, though it helps you track the history and lets you notice the variable has been changed.
Similar functions are listed below:
`setRegistry()`, `registerAddress()`, `unregisterAddress()`

Expand Down

0 comments on commit 8206d4a

Please sign in to comment.