Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback related to Vesting #25

Merged
merged 2 commits into from
Nov 30, 2017
Merged

Feedback related to Vesting #25

merged 2 commits into from
Nov 30, 2017

Conversation

Janther
Copy link

@Janther Janther commented Nov 29, 2017

New functionality

  • function claimTokens()
  • extra check for _holder != 0x0
  • The ability to finish the allocation before the initial vestingAmount has been reached

@Janther
adding claimTokens function an extra check for holderAddress and the …
78ef860 
…ability to finish the allocation before the initial vestingAmount has been reached
@Janther
extra check
82d644f
@coveralls
Copy link

coveralls commented Nov 29, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 83.333% when pulling 82d644f on vesting_contract into 2cafb6c on master.

matt-lough
matt-lough approved these changes Nov 29, 2017
View reviewed changes
Copy link

@matt-lough matt-lough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

coveralls commented Nov 29, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 83.333% when pulling 82d644f on vesting_contract into 2cafb6c on master.

@matt-lough matt-lough merged commit 7d46986 into master Nov 30, 2017
@matt-lough matt-lough deleted the vesting_contract branch November 30, 2017 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-lough matt-lough matt-lough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Janther @coveralls @matt-lough