Reconnect both when a signer attaches and when the RPC becomes available #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have an issue where the signer connecting earlier than the RPC is ready will result in the reconnects being lost. So now we trigger both when a signer first connects and when the RPC becomes available.
This is important so we don't lock up the `openingd` right from the get go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having issues with nodes not reconnecting some times. We traced the issue to the signer connecting very early on, when the RPC is not available yet, causing the
connect()calls yelling into the void.By refactoring the reconnection logic and calling it both from the RPC watcher and the signer connecting should address that.