client: Add keepalive to signer, scheduler and node connections #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
force-pushed
the
20230718-keepalive
branch
from
5bcf689
to
ea9e998
Compare
We can't clean if we use the bind mount directly.
Tonic allows us to setup keep alive messages in order to detect silent disconnections. We set up a conservative keepalive of 30s and a timeout of 90s. This should allow signers and clients to discover that they got disconnected (eventually) and re-connect, either to the node or the scheduler. Closes #209
This should allow us to better help users that are in trouble by detecting the exact version of the code they were running. Logging to stdout also does not leak these details to the service operators.
cdecker
force-pushed
the
20230718-keepalive
branch
from
ea9e998
to
a343ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to passively detect that we lost a connection after 90s. While not quite usable for interactive scenarios (signer in keep alive timeout, client is waiting on signatures), it is useful for the standard case where the signer lost the connection while waiting for the node to get scheduled.
A deeper integration with the host's sleep state, restarting the signer when we come back from suspension for example, can be a complementary technique to address those interactive scenarios.
Closes #209