Fix *Proof::from_str #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoComandini
force-pushed
the
2022-08-31-str-proofs
branch
from
6efb105
to
e3a63b3
Compare
|
ACK e3a63b3 looks like |
|
utACK. Agreed! I cannot run my local tests until #56 is fixed, but I think we're good to merge this. |
apoelstra
added a commit
that referenced
this pull request
Sep 1, 2022
98994ee ffi: fix signature of whitelist_sign (Andrew Poelstra) Pull request description: The signature of whitelist_sign in our FFI bindings did not match the signature in the C libarry. Noticed when running local tests on #55. Apparently wasm-pack notices stuff like this now and errors out :) ACKs for top commit: jonasnick: utACK 98994ee Tree-SHA512: a12d5260e2361aa2db06dbecf59f50a15aad1f04b5659dd265cc1bec01197e2b0c5378b903a0b5f6d4a39eeaf45bb69177bc32ef8e6b5733c9e006fcdf7d3c67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deserializing
RangeProofs andSurjectionProofs fromstrfails with current master.Add a fix and tests.