configure: Clean ups #290
Merged
configure: Clean ups #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the canonical order of modules? |
|
The one used for the echos, i.e., first the upstream modules (in their order) and then our modules in the ordered they appeared. And that order should be used in the other places, just sometimes reversed... Let me add a comment. (I just don't want to add a comment everywhere we list modules. This would again need to be done upstream, and I don't want to make that dance yet another time, at least not for an issue of this kind. :D) |
real-or-random
force-pushed
the
202402-module-cleanup
branch
3 times, most recently
from
fc4bb1b
to
8e7afe7
Compare
|
Updated. |
real-or-random
force-pushed
the
202402-module-cleanup
branch
from
8e7afe7
to
f5a67c3
Compare
|
Changed it again, so that the main idea can at least be ported to upstream easily. Really ready for review now. ^^ |
The variable set automatically by AC_ARG_ENABLE is called enable_...
real-or-random
force-pushed
the
202402-module-cleanup
branch
from
f5a67c3
to
860e3bb
Compare
jonasnick
reviewed
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.