Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda recipe for bloscpack #48

Merged
merged 1 commit into from
May 12, 2016
Merged

Conversation

ijstokes
Copy link
Contributor

recipe requires cram conda package (-c ijstokes conda channel) and currently comments out coveralls -- but otherwise builds

@coveralls
Copy link

coveralls commented Apr 28, 2016

Coverage Status

Coverage remained the same at 95.303% when pulling 476aa46 on ijstokes:ijstokes/conda_recipe into f9e5283 on Blosc:master.

@FrancescAlted
Copy link
Member

Thanks for that, but I think it would be better if we keep packaging config files out of the repo. Thoughts?

@esc
Copy link
Member

esc commented May 2, 2016

I don't think it matters much anymore. For python-blosc we did that:

https://github.com/Blosc/python-blosc-conda-recipe

I think I even made some binaries that I uploaded to the Blosc channel on anaconda.org:

https://anaconda.org/blosc

But on anaconda.org everyone just seems to do whatever they like anyway and there is a plethora of blosc packages from all sorts of different people:

https://anaconda.org/search?q=Blosc

So in the end, unless someone can provide technical arguments for where the conda packaging stuff should go, I really don't care.

@esc
Copy link
Member

esc commented May 2, 2016

We also did this for bcolz:

https://github.com/Blosc/bcolz-conda-recipe

But I don't think that recipe ever worked. In fact it seems to live in the repo too:

https://github.com/Blosc/bcolz/tree/master/conda.recipe

So yeah I am not sure.

From a continuous build/integration/deployment perspective, having the recipe in the repository would make it easier to build new development releases on travis and upload them automatically to PyPi and anaconda.org. That might be a nice feature to add as we transition into an automated continuous paradigm.

@esc
Copy link
Member

esc commented May 12, 2016

The failed test is due to an instability in the test, I am fixing it now.

@esc
Copy link
Member

esc commented May 12, 2016

Also, I would suggest to merge this for now. If it helps @ijstokes .

@esc
Copy link
Member

esc commented May 12, 2016

I restarted the command-line tests and everything is fine now. Also a fix for the test instability is here:

#49

@esc
Copy link
Member

esc commented May 12, 2016

Will merge this now, since it is green.

@esc esc merged commit fcd38af into Blosc:master May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants