fix codec enumeration (in README) #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon further inspection of the Blosc source code the changes made to the header README in 8707b4c must be reverted, my bad. As it turns out, there is now one set of integers used internally by blosc as arguments to compress and another that is actually used to identify the codec in the header. I presume that since LZ4 and LZ4HC have the same decompressor, the same integer (namely ``1``) is used for both. Updated the docs to account for that. Also, it turns out that the field that was previously used for the version of the blosclz is now more general and stores the version of the codec used. Updated the README to reflect that change.
|
Great. Thanks! |
FrancescAlted
pushed a commit
that referenced
this pull request
Feb 2, 2014
fix codec enumeration (in README)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon further inspection of the Blosc source code the changes made to the header
README in 8707b4c must be reverted, my bad. As
it turns out, there is now one set of integers used internally by blosc as
arguments to compress and another that is actually used to identify the codec
in the header. I presume that since LZ4 and LZ4HC have the same decompressor,
the same integer (namely
1) is used for both. Updated the docs to accountfor that.
Also, it turns out that the field that was previously used for the version of
the blosclz is now more general and stores the version of the codec used.
Updated the README to reflect that change.