Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake Install: Find*.cmake Modules #542

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

ax3l
Copy link
Contributor

@ax3l ax3l commented Aug 18, 2023

Install the CMake modules in cmake/ into our install prefix. If we build with external dependencies for LZ4 and ZLIB_NG, then downstream projects will need those Modules to populate our CMake import targets in Blosc2Config.cmake during the find_dependency calls (which are just wrappers for find_package).

Follow-up to #537 and #541.

Install the CMake modules in `cmake/` into our install
prefix. If we build with external dependencies for LZ4 and ZLIB_NG,
will need those Modules to populate our CMake import targets in
`Blosc2Config.cmake` during the `find_dependency` calls (which
are just wrappers for `find_package`).
@ax3l
Copy link
Contributor Author

ax3l commented Aug 18, 2023

@FrancescAlted this is ready to go and tested with conda-forge/c-blosc2-feedstock#42 and ADIOS2 as downstream dependency that consumes C-Blosc2 + transitive external dependencies. (My tests in #537 used internally shipped dependencies.)

If you like, after this is merged, maybe we could tag a new patch release and skip 2.10.1 on CF in favor of 2.10.2?
Alternatively, I can show you how to patch these two PRs into conda-forge/c-blosc2-feedstock#42

@ax3l
Copy link
Contributor Author

ax3l commented Aug 18, 2023

P.S.: There is a typo in my last name in https://github.com/Blosc/c-blosc2/releases/tag/v2.10.1 :)

@FrancescAlted
Copy link
Member

P.S.: There is a typo in my last name in https://github.com/Blosc/c-blosc2/releases/tag/v2.10.1 :)

Oops. Fixed!

@FrancescAlted
Copy link
Member

@FrancescAlted this is ready to go and tested with conda-forge/c-blosc2-feedstock#42 and ADIOS2 as downstream dependency that consumes C-Blosc2 + transitive external dependencies. (My tests in #537 used internally shipped dependencies.)

If you like, after this is merged, maybe we could tag a new patch release and skip 2.10.1 on CF in favor of 2.10.2? Alternatively, I can show you how to patch these two PRs into conda-forge/c-blosc2-feedstock#42

Thanks. Let's wait for 2.10.2, which should be released pretty soon.

@FrancescAlted FrancescAlted merged commit d190856 into Blosc:main Aug 18, 2023
16 checks passed
@ax3l ax3l deleted the fix-install-cmake-modules branch August 18, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants