bytedelta: rely on __SSSE3__ macro rather that on architecture macros #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
commented
Feb 7, 2024
| #define __SSSE3__ | ||
| #endif | ||
|
|
||
| #if defined(__SSSE3__) |
There was a problem hiding this comment.
It assumes that SSE2 is available when SSSE3 is
t20100
added a commit
to t20100/hdf5plugin
that referenced
this pull request
Feb 7, 2024
|
LGTM. Indeed the Windows platform was not fully tested. Thanks @t20100 ! |
t20100
added a commit
to t20100/hdf5plugin
that referenced
this pull request
Feb 7, 2024
t20100
added a commit
to t20100/hdf5plugin
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to use the
__SSSE3__macros to probe SSSE3 availability rather than the architecture macros since this depends on the build options used. From what I have checked the bytedelta code uses only SSSE3 and SSE2 instructions.For Visual Studio,
__SSSE3__is defined the same way as for__SSE2__in:https://github.com/Blosc/C-Blosc2/blob/f0183767d73073eb41bbf97bf56554c7a55c7dbf/include/blosc2/blosc2-common.h#L36-L43
Related to #546 and probably fixes it. From what I have tested, it fixes build issues with hdf5plugin.