Blosc as subtree #15
Closed
Blosc as subtree #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THIS IS JUST AN EXPERIMENTAL COMMIT. DO NOT MERGE ME!!
|
This is awesome. I really like the subtree approach better than the submodule one. I would like to merge this PR, but I suppose I cannot do that automatically, right? So the best would be to individually pick every commit here from your repo, except the one labeled as 'do not merge'? Thanks, |
|
After pondering on it some more, I also thing the subtree approach is the best one for this use-case. The Blosc sources are small, and this is very much like the previous approach. Except that we have formalized a little how the sources get merged. I will push a new PR which can be merged automatically. |
|
See: #23. Will close all the others ones. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtree version. The last commit is just an example of a subtree update would look and should not be merged.