Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NaN in JSON Feature #169

Merged
merged 8 commits into from
Jan 26, 2024
Merged

Fix NaN in JSON Feature #169

merged 8 commits into from
Jan 26, 2024

Conversation

ilkilic
Copy link
Contributor

@ilkilic ilkilic commented Jan 26, 2024

  • Fix NaN values in JSON
  • Ensure 'current' array operations use float64 to prevent casting error
  • Refactor sAHP unit test
  • Add APThreshold unit test

@ilkilic ilkilic self-assigned this Jan 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (0ae5960) 71.35% compared to head (d799ed0) 73.94%.

Files Patch % Lines
bluepyefe/ecode/DeHyperPol.py 0.00% 3 Missing ⚠️
bluepyefe/ecode/HyperDePol.py 0.00% 3 Missing ⚠️
bluepyefe/ecode/SpikeRec.py 0.00% 3 Missing ⚠️
bluepyefe/ecode/negCheops.py 0.00% 1 Missing ⚠️
bluepyefe/ecode/posCheops.py 0.00% 1 Missing ⚠️
tests/ecode/test_apthresh.py 98.14% 1 Missing ⚠️
tests/ecode/test_sahp.py 98.18% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #169      +/-   ##
==========================================
+ Coverage   71.35%   73.94%   +2.58%     
==========================================
  Files          36       38       +2     
  Lines        2304     2391      +87     
==========================================
+ Hits         1644     1768     +124     
+ Misses        660      623      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@AurelienJaquier AurelienJaquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @ilkilic

@ilkilic ilkilic merged commit e438278 into master Jan 26, 2024
4 checks passed
@ilkilic ilkilic deleted the json-nan-to-null branch January 26, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants