Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events from Deflect are not broadcasted via Rockets #342

Closed
tribal-tec opened this issue Mar 7, 2018 · 0 comments · Fixed by #533
Closed

Events from Deflect are not broadcasted via Rockets #342

tribal-tec opened this issue Mar 7, 2018 · 0 comments · Fixed by #533
Labels
bug
Milestone
Brayns 0.7

Comments

@tribal-tec
Copy link
Contributor

tribal-tec commented Mar 7, 2018 •
edited
Loading

Today, only modifications on camera, settings, etc. by braynsViewer are broadcasted in RocketsPlugin. We don't want to that for braynsService as in between the async render, new changes might be received and then they will be send back to the sender.

To cleanly fix this, we probably would need to double-buffer all objects to separate changes for the current and the next frame. As long as braynsViewer does not become asynchronous this is not needed.

As a result, events sent by Deflect are not broadcasted in RocketsPlugin in the braynsService case.
@tribal-tec tribal-tec added the bug label Mar 7, 2018
@tribal-tec tribal-tec added this to the Brayns 0.7 milestone Aug 24, 2018
tribal-tec added a commit to tribal-tec/Brayns that referenced this issue Aug 24, 2018
@tribal-tec
Immediate notify on change with throttling (fixes BlueBrain#342)
5c2c5f1
tribal-tec added a commit to tribal-tec/Brayns that referenced this issue Aug 27, 2018
@tribal-tec
Immediate notify changes on the websocket
613c5aa 
This fixes several issues regarding updates of objects that are not modified
by a rockets client, e.g. updates from plugins or programmatic updates like
the animation update while playback. It simplifies the postRender() logic a
lot, and also fixes BlueBrain#342.

To avoid excessive update 'spam', throttling is used on the change callbacks.
@tribal-tec tribal-tec mentioned this issue Aug 27, 2018
Merged
tribal-tec added a commit to tribal-tec/Brayns that referenced this issue Aug 28, 2018
@tribal-tec
Immediate notify changes on the websocket
008001b 
This fixes several issues regarding updates of objects that are not modified
by a rockets client, e.g. updates from plugins or programmatic updates like
the animation update while playback. It simplifies the postRender() logic a
lot, and also fixes BlueBrain#342.

To avoid excessive update 'spam', throttling is used on the change callbacks.
tribal-tec added a commit to tribal-tec/Brayns that referenced this issue Aug 28, 2018
@tribal-tec
Immediate notify changes on the websocket
ec0b661 
This fixes several issues regarding updates of objects that are not modified
by a rockets client, e.g. updates from plugins or programmatic updates like
the animation update while playback. It simplifies the postRender() logic a
lot, and also fixes BlueBrain#342.

To avoid excessive update 'spam', throttling is used on the change callbacks.
tribal-tec added a commit to tribal-tec/Brayns that referenced this issue Aug 28, 2018
@tribal-tec
Immediate notify changes on the websocket
6ce08eb 
This fixes several issues regarding updates of objects that are not modified
by a rockets client, e.g. updates from plugins or programmatic updates like
the animation update while playback. It simplifies the postRender() logic a
lot, and also fixes BlueBrain#342.

To avoid excessive update 'spam', throttling is used on the change callbacks.
tribal-tec added a commit that referenced this issue Aug 28, 2018
@tribal-tec
Immediate notify changes on the websocket
ff4f281 
This fixes several issues regarding updates of objects that are not modified
by a rockets client, e.g. updates from plugins or programmatic updates like
the animation update while playback. It simplifies the postRender() logic a
lot, and also fixes #342.

To avoid excessive update 'spam', throttling is used on the change callbacks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Brayns 0.7
Development

Successfully merging a pull request may close this issue.

Immediate notify changes on the websocket tribal-tec/Brayns
1 participant
@tribal-tec