Added CircuitConfigurationBuilder Rest API #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdumusc
reviewed
Sep 5, 2017
| @@ -20,6 +20,8 @@ | |||
|
|
|||
| #include "ZeroEQPlugin.h" | |||
|
|
|||
| #include <ZeroEQ/zeroeq/http/helpers.h> | |||
There was a problem hiding this comment.
won't work if ZeroEQ package is in an installed location.
#include <zeroeq/http/helpers.h>
| blueConfig << param << std::endl; | ||
| } | ||
| blueConfig << "}" << std::endl; | ||
| blueConfig.close(); |
There was a problem hiding this comment.
make a second function:
bool _writeBlueConfigFile(const std::string& filename, const strings& params);
| ::zeroeq::http::Code::SERVICE_UNAVAILABLE); | ||
|
|
||
| blueConfig << "Run Default" << std::endl << "{" << std::endl; | ||
| for (auto param : params) |
rdumusc
approved these changes
Sep 5, 2017
|
I don't know if this is a can of worms that we want to open now, but I think that CircuitConfig are already being registered in the neuroinformatics platform with unique IDs and that you can get either the path or the text from it. I'd make sense to track what's the progress there and consider adding support for this in Brion or viztools |
|
I'm saying this because (without knowing the precise details) this commit doesn't look to be in the right place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.