Cache file fixes #229
Merged
Cache file fixes #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tribal-tec
commented
Oct 18, 2017
tribal-tec
commented
- Optimize reading speed, total loading time went from ~140 to ~60 seconds
- Fix missing progress update
- Don't build default scene when loading cache file
* Optimize reading speed, total loading time went from ~140 to ~60 seconds * Fix missing progress update * Don't build default scene when loading cache file
rdumusc
approved these changes
Oct 18, 2017
| @@ -921,7 +906,7 @@ void OSPRayScene::buildGeometry() | |||
| BRAYNS_INFO << "---------------------------------------------------" | |||
| << std::endl; | |||
|
|
|||
| if (!_parametersManager.getGeometryParameters().getSaveCacheFile().empty()) | |||
| if (!geomParams.getSaveCacheFile().empty()) | |||
There was a problem hiding this comment.
this should be outside the buildGeometry() function
plugins/engines/ospray/OSPRayScene.h
Outdated
| @@ -91,7 +94,6 @@ class OSPRayScene : public brayns::Scene | |||
| uint64_t _serializeCones(const size_t materialId); | |||
| uint64_t _buildMeshOSPGeometry(const size_t materialId); | |||
|
|
|||
| void _loadCacheFile(); | |||
| void _saveCacheFile(); | |||
There was a problem hiding this comment.
if saveSceneToCacheFile is empty, move contents to saveSceneToCacheFile()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.