Extend snapshot params; fix #360; bugfixes #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
force-pushed
the
snapshot_improvements
branch
from
0a75671
to
a43114b
Compare
tribal-tec
force-pushed
the
snapshot_improvements
branch
from
a43114b
to
15241e3
Compare
hernando
reviewed
May 1, 2018
| @@ -200,7 +201,8 @@ class Camera : public BaseObject | |||
| BRAYNS_API void reset(); | |||
|
|
|||
| /** Enable/disables environment mapping */ | |||
| BRAYNS_API virtual void setEnvironmentMap(const bool environmentMap) = 0; | |||
| BRAYNS_API virtual void setEnvironmentMap( | |||
| const bool environmentMap BRAYNS_UNUSED){}; | |||
There was a problem hiding this comment.
Shouldn't the environment map be part of the scene?
tribal-tec
changed the title
favreau
approved these changes
May 2, 2018
|
retest this please |
1 similar comment
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.