Upgrade to Deflect 1.0, fix build without Brion #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2018 13:23
|
retest this please |
tribal-tec
approved these changes
May 18, 2018
|
Do you have an idea about the unit test that failed twice already in cscs-debug: addModel (SEGFAULT) |
|
Not really... I saw it once too, but the next retrigger worked then. No idea where this comes from, and can be of course not reproduced locally... |
|
OK... I'll try to retest this please a 3rd time then... |
tribal-tec
suggested changes
May 18, 2018
There was a problem hiding this comment.
While I agree with the version check in general, EXACT is not correct. It should be "up to", because 1.3 and 1.4 (maybe even older) also works. The problem now is, that the cluster build doesn't do anything meaningful, because it builds now Brayns w/o ospray, as the module is on version 1.4.
|
retest this please |
tribal-tec
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.