Add chunk ID and chunk RPC to support concurrent request-model-upload RPCs; bugfixes #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandjitsu
approved these changes
May 18, 2018
|
retest this please |
1 similar comment
|
retest this please |
tribal-tec
changed the title
rdumusc
reviewed
May 23, 2018
| std::lock_guard<std::mutex> lock(_mutex); | ||
| _binaryRequests.emplace(std::make_pair(clientID, param.chunksID), task); | ||
| _requests.emplace(task, std::make_pair(clientID, param.chunksID)); | ||
| _nextChunk = param.chunksID; |
|
|
||
| return task; | ||
| } | ||
|
|
||
| void setNextChunk(const size_t id) { _nextChunk = id; } |
| std::map<std::pair<uintptr_t, size_t>, | ||
| std::shared_ptr<AddModelFromBlobTask>> | ||
| _binaryRequests; | ||
| std::map<TaskPtr, std::pair<uintptr_t, size_t>> _requests; |
There was a problem hiding this comment.
having a typedef for std::pair<uintptr_t, size_t> would be nice here
maybe try to clarify what is _requests and _binaryRequests
tests/ClientServer.h
Outdated
| _brayns->preRender(); | ||
| _wsClient.process(CLIENT_PROCESS_TIMEOUT); | ||
| for (size_t i = 0; i < SERVER_PROCESS_RETRIES; ++i) | ||
| _brayns->preRender(); |
There was a problem hiding this comment.
Check the above, not exactly retires at the preRender is always executed n times
Also avoid excessive markModified() of the scene as this leads to lots of unnecessary broadcasts of the scene during simulation playback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.