Remove submodels in favor of proper instances support #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- one level of models in the scene; don't get too crazy adding tons of models, as the models are part of the scene JSON - list of instances in ModelDescriptor; default instance for added model is created; instances are created via addInstance() - add get-instances and update-instance as a first exposure to clients
favreau
approved these changes
May 29, 2018
| auto instance = model->getInstance(newDesc.getInstanceID()); | ||
| if (!instance) | ||
| throw rockets::jsonrpc::response_error("Instance not found", | ||
| -12346); |
There was a problem hiding this comment.
We should probably store those error ids as globals into a single file, and expose them in the documentation for the JS and Python SDKs to use them accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.