Deflect-related improvements: stream & accum frames cmdline, render throttling #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdumusc
reviewed
Jun 1, 2018
| const int64_t targetTime = (1. / fps) * 1000.f; | ||
| std::this_thread::sleep_for(std::chrono::milliseconds( | ||
| targetTime - _renderTimer.milliseconds())); | ||
| } |
There was a problem hiding this comment.
This should either be called only when streaming is enabled, or the parameter should be renamed from imageStreamFPS to something more generic (with a way to adjust/disable it when benchmarking performance).
There was a problem hiding this comment.
I don't want to rename it now to not break the web API. It can already be changed on the commandline.
There was a problem hiding this comment.
OK, I would still rename it everywhere else, but up to you.
There was a problem hiding this comment.
I added a different parameter for this now. The tests were using the existing FPS to 'disable' streaming to speed up the execution of the tests. It also breaks nothing else at the moment hopefully.
rdumusc
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.