Stricter arguments parsing #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
reviewed
Jun 5, 2018
brayns/Brayns.cpp
Outdated
| @@ -143,12 +144,20 @@ struct Brayns::Impl : public PluginAPI | |||
| << "' is not a valid Brayns plugin; missing " | |||
| "brayns_plugin_create()" | |||
| << std::endl; | |||
| return; | |||
| exit(0); | |||
There was a problem hiding this comment.
(...or throw to have a single exit point below)
tribal-tec
reviewed
Jun 5, 2018
brayns/Brayns.cpp
Outdated
| Brayns::~Brayns() | ||
| { | ||
| } | ||
| Brayns::~Brayns() {} |
There was a problem hiding this comment.
This needs to be in the cpp file due to the pimpl pattern.
tribal-tec
reviewed
Jun 5, 2018
| @@ -82,6 +88,8 @@ class ApplicationParameters : public AbstractParameters | |||
| _updateValue(_synchronousMode, synchronousMode); | |||
| } | |||
|
|
|||
| bool getParallelRendering() { return _parallelRendering; } | |||
tribal-tec
reviewed
Jun 5, 2018
| @@ -79,6 +78,7 @@ void ParametersManager::parse(int argc, const char** argv) | |||
| catch (po::error& e) | |||
| { | |||
| BRAYNS_ERROR << e.what() << std::endl; | |||
| exit(0); | |||
tribal-tec
reviewed
Jun 5, 2018
| } | ||
|
|
||
| ospInit(&argc, newArgv.data()); | ||
| ospInit(&argc, argv.data()); |
There was a problem hiding this comment.
for consistency, argv[0] should be still the app name imo. I don't know if ospray needs that internally or expects it to be there.
karjonas
force-pushed
the
arguments_parsing
branch
from
af700fd
to
add55aa
Compare
|
Issues fixed and rebased. |
tribal-tec
approved these changes
Jun 5, 2018
added 12 commits
June 6, 2018 09:58
Also remove the passing of all arguments to ospray init.
The plugin arguments are parsed by Brayns and then added as argc, argv variables during the creation of the plugin.
karjonas
force-pushed
the
arguments_parsing
branch
from
add55aa
to
485a901
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make Brayns exit if invoked with incorrect arguments. It also add the possibility to add arguments to plugins.