Introduce camera-specific properties and runtime type switching #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
force-pushed
the
camera
branch
3 times, most recently
from
21a64ff
to
a129978
Compare
rolandjitsu
approved these changes
Jul 12, 2018
brayns/common/PropertyMap.h
Outdated
| , type(_getType<T>()) | ||
| , _data(value) | ||
| , _min(min_) | ||
| , _max(max_) | ||
| , _min(limits.first) |
There was a problem hiding this comment.
Should it not be just limit and limit.min/limit.max? limits would implies there is a set of limit pairs.
| { | ||
| auto value = prop.get<T>(); | ||
| jsonSchema = | ||
| staticjson::export_json_schema(&value, &schema.GetAllocator()); |
There was a problem hiding this comment.
Could make a const out of schema.GetAllocator()?
Also add enum support (type int with list of strings) to PropertyMap to expose them property in JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.