Changed warning trace to error if color scheme by layer is choosen for MVD2 circuits #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
suggested changes
Aug 13, 2018
| @@ -307,10 +307,10 @@ class CircuitLoader::Impl | |||
| } | |||
| catch (...) | |||
| { | |||
| BRAYNS_WARN << "Only MVD2 format is currently supported by Brion " | |||
There was a problem hiding this comment.
Just print the message if ' Color scheme by layer' was requested? Then it should be an error.
There was a problem hiding this comment.
Now the commit message and the PR message don't match anymore.
There was a problem hiding this comment.
Why do you do this check in the try/catch and not before? This hides other exceptions then.
favreau
changed the title
favreau
force-pushed
the
master
branch
4 times, most recently
from
6078776
to
59c051b
Compare
tribal-tec
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.