Add --circuit-random-seed command line flag. #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
hernando
approved these changes
Aug 21, 2018
| @@ -152,6 +153,8 @@ GeometryParameters::GeometryParameters() | |||
| "Minimum and maximum values for the simulation [float float]")( | |||
| PARAM_CIRCUIT_SIMULATION_HISTOGRAM_SIZE.c_str(), po::value<size_t>(), | |||
| "Number of values defining the simulation histogram [int]")( | |||
| PARAM_CIRCUIT_RANDOM_SEED.c_str(), po::value<size_t>(), | |||
There was a problem hiding this comment.
I'd use const char* for all these strings if you really need the C representation in the end
There was a problem hiding this comment.
Seems reasonable, but that is for another PR.
|
retest this please |
This makes the circuit loading deterministic by default. To get randomness --circuit-random-seed is used. Using BRAIN_CIRCUIT_SEED is no longer supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the circuit loading deterministic by default. To get randomness --circuit-random-seed is used. Using BRAIN_CIRCUIT_SEED is no longer supported.