Moved circuit and morphology loaders to the new CircuitViewer plugin #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rename the title so it fits please, for instance "Move circuit and morphology loaders into new plugin 'CircuitViewer'". |
hernando
changed the title
Brayns initialization modified: - Plugin loading now happens in the constructor, as it's needed to register loaders from the new CircuitViewer plugin before loading occurs. - In braynsService event loop setup must be done before creating the Brayns instance.
hernando
changed the title
hernando
force-pushed
the
circuit_viewer_plugin
branch
from
bc47c35
to
d888333
Compare
karjonas
approved these changes
Nov 14, 2018
tribal-tec
reviewed
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brayns initialization modified:
loaders from the new CircuitViewer plugin before loading occurs.
Brayns instance.