Add support for multiple frameBuffers #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tribal-tec
force-pushed
the
master
branch
2 times, most recently
from
f937354
to
f89ef29
Compare
rdumusc
previously approved these changes
Nov 20, 2018
hernando
reviewed
Nov 20, 2018
hernando
reviewed
Nov 20, 2018
tribal-tec
force-pushed
the
master
branch
5 times, most recently
from
bb7c941
to
431d602
Compare
This is to support streaming stereo eye passes and deflect channels (Tide surfaces) from plugins w/o having the core to know anything about that. The frameBuffer names mean only something within the DeflectPlugin and other plugins leveraging from that (e.g. OpenDeck). Furthermore, this simplifies how stereo is handled, as this is just a specializiaton of a multi buffer setup. For this, "--stereo" has been added to the commandline args, which will create two buffers (one for each eye) at startup. Side-by-side stereo output is implemented in braynsViewer, though the viewer will output all buffers next to each other that have been added to Brayns.
|
All should be good now |
hernando
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.