Removal of metaball and layout options from morphology loading. #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karjonas
reviewed
Nov 27, 2018
tribal-tec
reviewed
Nov 28, 2018
brayns/Brayns.cpp
Outdated
| } | ||
|
|
||
| pm.addProperty({"dampenBranchThicknessChangerate", |
There was a problem hiding this comment.
moreBeautifulBranches? any name is probably terrible, do we need this option really?
There was a problem hiding this comment.
That's not what it means (which shows it's a bad name). I suggested lowPassSectionRadius, reduceRadiusVariation or similar, because that's what the option actually does. It's not reducing the change rate (samples stay where they are), but the difference between samples.
hernando
force-pushed
the
removals_and_refactorings
branch
4 times, most recently
from
8de937f
to
32530b8
Compare
|
Retest this please |
Arranging morphologies after loading can be easily done with a Python scripts, as morphologies are imported as separate models if loaded from a directory. "circuit" and "morphology" prefixes stripped from loading parameters of the CircuitViewer plugin. "Mesh transformation" renamed to "transform meshes" Refactorings.
hernando
force-pushed
the
removals_and_refactorings
branch
from
32530b8
to
18a2783
Compare
|
Retest this please |
1 similar comment
|
Retest this please |
|
ping |
karjonas
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arranging morphologies after loading can be easily done with a Python
scripts, as morphologies are imported as separate models if loaded from
a directory.
"circuit" and "morphology" prefixes stripped from loading parameters of
the CircuitViewer plugin.
"Mesh transformation" renamed to "transform meshes"
Refactorings.