Refactor subsampling into its own property #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolandjitsu
previously approved these changes
Jan 24, 2019
karjonas
previously approved these changes
Jan 24, 2019
hernando
reviewed
Jan 24, 2019
| const char* argv[] = { | ||
| app, "--renderer", "proximity", "--samples-per-pixel", | ||
| "256", "demo", "--window-size", "400", | ||
| "300"}; |
There was a problem hiding this comment.
It's clang that does it 😄
There was a problem hiding this comment.
Yes, and it will do it again, that's why I suggest to remove the spaces and give up on the original format.
There was a problem hiding this comment.
the spaces are added (back) by clang-format...
There was a problem hiding this comment.
Actually, clang-format is making 4 columns...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.