Fixed morphology loading - Diameter vs radius #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests need fixing. |
| @@ -201,7 +201,7 @@ bool MorphologyLoader::_importMorphology( | |||
| const float previousRadius = | |||
| (_geometryParameters.getRadius() < 0.f ? | |||
| -_geometryParameters.getRadius() : | |||
| samples[ i - step ].w() * _geometryParameters.getRadius( )); | |||
| samples[ i - step ].w() * 0.5f * _geometryParameters.getRadius( )); | |||
There was a problem hiding this comment.
Why not getRadiusFactor or getRadiusMultiplier?
Even better, you could add the function float correctRadius(float radius) in GeometryParameters to do this entire operation. This way you woudn't have to use a negative value to force an absolute value (which is a trick I'd rather avoid).
There was a problem hiding this comment.
Good point! Thanks. Working on it.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.