Ban obsolete morphology repair stage from API #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eile
force-pushed
the
stage
branch
2 times, most recently
from
ca5015d
to
0da04c1
Compare
added 2 commits
August 3, 2017 09:47
Was only used for deprecated h5 v2 morphologies. Contract for all other file types was undefined and leaked through the API. New impl will read latest repair stage and will write repaired morphologies.
hernando
reviewed
Aug 3, 2017
| dataset = _file.openDataSet("/" + _g_root + "/" + toString(stage) + | ||
| "/" + _d_points); | ||
| dataset = _file.openDataSet("/" + _g_root + "/" + _stage + "/" + | ||
| _d_points); |
There was a problem hiding this comment.
You have changed the default semantics here. Are you sure there's no tool using v2 morphologies that would be affected by this change?
There was a problem hiding this comment.
In any case this has to be documented/mentioned in the changelog.
hernando
approved these changes
Aug 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.