Fixed brain::circuit methods to not crash with empty gids lists #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernando
force-pushed
the
empty_gids_fix
branch
from
bc8625b
to
8b8ffdd
Compare
tribal-tec
approved these changes
Jan 17, 2018
tribal-tec
reviewed
Jan 17, 2018
tests/brain/circuit.cpp
Outdated
| brion::GIDSet nil; | ||
| BOOST_CHECK(mvd2.getPositions(nil).empty()); | ||
| BOOST_CHECK(mvd2.getTransforms(nil).empty()); | ||
| BOOST_CHECK(mvd2.getMorphologyNames(nil).empty()); |
There was a problem hiding this comment.
getRotations() is missing?
There was a problem hiding this comment.
getTransforms uses the the same code path than getRotations, but I can add it.
hernando
force-pushed
the
empty_gids_fix
branch
from
8b8ffdd
to
4f1de4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.