Allow to open BlueConfig from memory buffer #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernando
suggested changes
Apr 25, 2018
| buffer << file.rdbuf(); | ||
| } | ||
| else | ||
| buffer << source; |
There was a problem hiding this comment.
I don't like this implementation very much because it will make errors about inexistent files misleading. What about another constructor that takes a char*?
There was a problem hiding this comment.
I didn't want to advertise this as a real feature, hence hiding it behind the existing API was fine enough for me. It's purpose is not very useful anyways, as the BlueConfig just redirects to other paths. It's nice for a show-case, but in reality you have to open the file close to where all the other referenced entities reside.
So I'm gonna close this then.
There was a problem hiding this comment.
Much more useful would be a remote file browser in Sauron ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.