Morphology recentering for SONATA circuits. #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Circuit::getAttribute to retrieve custom node attributes from SONATA circuits.
karjonas
reviewed
Jun 7, 2018
brain/circuit.cpp
Outdated
| size_t numRecentered = 0; | ||
| size_t numOriginal = 0; | ||
| }; | ||
| using Loading = std::unordered_map<std::string, MorphologyUse>; |
There was a problem hiding this comment.
In the beginning I thought I was going to use this type more than once.
|
I'm trying to provide a test (despite it's quite annoying), but I won't be able to test all combinations. To me this is the type of code that is better to review thoroughly rather than rely on tests and coverage. The tests need to be white box to guarantee coverage and given the amount of combinations 100% coverage doesn't guarantee very much. |
hernando
force-pushed
the
recentering
branch
4 times, most recently
from
5d10241
to
7883dfe
Compare
|
Done. I also fixed a couple of bugs I found out while doing it and testing with the sample circuit I have |
The dataset names used for rotation angles had a typo. The indexing used to access node properties from the model types CSV was wrong (it was mixing gids and node types ids). Fixed typo in rotation angle attribute names.
|
Retest this please |
karjonas
reviewed
Jun 11, 2018
| auto transforms = circuit.getTransforms({0, 2}); | ||
| morphologies = | ||
| circuit.loadMorphologies({0, 2}, brain::Circuit::Coordinates::global); | ||
| BOOST_CHECK_EQUAL(morphologies[0]->getSoma().getCentroid(), |
There was a problem hiding this comment.
Are all transforms identity in the test case?
There was a problem hiding this comment.
No, how do you reach that conclusion?
karjonas
approved these changes
Jun 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Circuit::getAttribute to retrieve custom node attributes
from SONATA circuits.