Fix currentDir handling #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* if CurrentDir isn't in the BlueConfig, it should default to the path
where the BlueConfig is, using the absolute path in this patch
* if a BlueConfig in the current directory is passed, `adjust_path`
would be called with ("BlueConfig", "", ".") if OutputPath is "."
this would return the `fullPath = currentDir + "/" + cleanPath; `
`/.` since currentDir is empty, and this path exists. This would mean
the URI wasn't correct
|
Thanks a lot, it has always been something that wasn't fully complying with the doc. |
NadirRoGue
approved these changes
Apr 13, 2022
|
No worries, thanks for accepting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where the BlueConfig is, using the absolute path in this patch
adjust_pathwould be called with ("BlueConfig", "", ".") if OutputPath is "."
this would return the
fullPath = currentDir + "/" + cleanPath;/.since currentDir is empty, and this path exists. This would meanthe URI wasn't correct