QmlStreamer: Use asynchronous rendering and image streaming; reuse QuickRenderer from Tide #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdumusc
reviewed
Oct 28, 2016
| @@ -9,11 +9,13 @@ set(DEFLECTQT_HEADERS | |||
| QmlStreamerImpl.h | |||
| ) | |||
| set(DEFLECTQT_PUBLIC_HEADERS | |||
| QuickRenderer.h | |||
There was a problem hiding this comment.
alphabetical order: u after m (also below)
| * After construction, move the object to a dedicated render thread before | ||
| * calling any other function. | ||
| * | ||
| * @param quickWindow the window to render into if not @sa offscreen |
There was a problem hiding this comment.
could be clarified - how is it used when offscreen
There was a problem hiding this comment.
Humm forget this remark, I'm reading it again and the class description + offscreen parameter description contain enough information.
|
|
||
| signals: | ||
| /** Emitted at the end of render(). Originates from render thread. */ | ||
| void afterRender(); |
There was a problem hiding this comment.
From the changes in Tide, I see that it is necessary to connect this signal to do the swapBuffer when not in offscreen mode, right? Maybe add that to the doc?
|
|
||
| _context->makeCurrent( _getSurface( )); | ||
|
|
||
| _ensureFBO(); |
There was a problem hiding this comment.
I would find it clearer to do:
if( offscreen )
_ensureFBO();
instead of:
void QuickRenderer::_ensureFBO()
if( !_offscreen )
return;
…ickRenderer from Tide
rdumusc
approved these changes
Oct 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.