This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
Speedup loading for full circuits (using circuit target), minor cleanups #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest this please |
| * @param params the URI parameters to obtain BlueConfig and target name | ||
| * @return the loaded set of GIDs | ||
| */ | ||
| inline brion::GIDSet getGIDs( const URIHandler& params ) |
There was a problem hiding this comment.
You can pass the BlueConfig to this function. You already have one when the function is used.
There was a problem hiding this comment.
But params.getTarget() in the next line won't work then.
Gained an improvement from 12 seconds to 0.5 seconds loading spikes for the 3Mio HPC circuit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gained an improvement from 12 seconds to 0.5 seconds loading spikes for
the 3Mio HPC circuit.