This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
Fix the volume writing when there are dots in the output path #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hernando
suggested changes
Oct 13, 2016
|
|
||
| // Consider only the filename to check whether there is an extension or not | ||
| const std::string& fileName = | ||
| filePath.substr( filePath.find_last_of("/") + 1 ); |
There was a problem hiding this comment.
This is wrong, if there is no / find_last_of returns std::npos and I don't know what std::npos + 1 returns (if it's defined at all), but most probably 0.
There was a problem hiding this comment.
Right. It was working without a problem just because npos = 18446744073709551615, so fileName = filePath.
Fixed now.
When a "." was present in the specified --output path, the voxelize app was failing to find the extension, leading to unexpected behaviors. Now only the file name is considered to search for the extension. Also, now it's possible to write also series of volumes using a different format than the default (.mhd).
hernando
approved these changes
Oct 13, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a "." was present in the specified --output path, the voxelize
app was failing to find the extension, leading to unexpected behaviors.
Now only the file name is considered to search for the extension.
Also, now it's possible to write also series of volumes using a different
format than the default (.mhd).