Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed implementation of user type construction for std::complex #128

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Fixed implementation of user type construction for std::complex #128

merged 1 commit into from
Sep 19, 2018

Conversation

hernando
Copy link
Contributor

No description provided.

@hernando hernando mentioned this pull request Sep 14, 2018
Closed
@karjonas
Copy link
Contributor

What was broken?

@hernando
Copy link
Contributor Author

You can read it in #127

@karjonas
Copy link
Contributor

lgtm

@hernando
Copy link
Contributor Author

@ferdonline any comments or can you approve?

@henryiii henryiii mentioned this pull request Sep 17, 2018
Merged
@henryiii
Copy link
Contributor

Is there a reason there is no test with a std::complex in the test suite?

ferdonline
ferdonline approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@ferdonline ferdonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hernando hernando merged commit e472a7f into BlueBrain:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferdonline ferdonline ferdonline approved these changes

@karjonas karjonas Awaiting requested review from karjonas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hernando @karjonas @henryiii @ferdonline