Fix build of parallel #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should not |
alkino
force-pushed
the
fix_parallel
branch
2 times, most recently
from
0ddcb7f
to
52fab73
Compare
|
|
|
We merge like that? |
ferdonline
reviewed
Oct 31, 2019
| @@ -10,12 +10,12 @@ target_compile_definitions(HighFive INTERFACE ${HDF5_DEFINITIONS}) | |||
|
|
|||
| # MPI | |||
| if(HIGHFIVE_PARALLEL_HDF5) | |||
| target_include_directories(HighFive SYSTEM INTERFACE ${MPI_C_INCLUDE_PATH}) | |||
| target_link_libraries(HighFive INTERFACE ${MPI_C_LIBRARIES}) | |||
| target_include_directories(HighFive SYSTEM INTERFACE ${MPI_CXX_INCLUDE_PATH}) | |||
There was a problem hiding this comment.
Were these changes required to it to succeed? Or is it just an improvement?
I believe not, it would be one more dependency. However, in our internal stack with Spack, yes, we should build with mpi by default. |
We now cover the scenarios of installing hdf5 / build HighFive: - serial / serial - parallel / parallel - parallel / serial
|
We should support the scenario added (using a parallel hdf5 but compile serial apps) |
|
Really good catch, I fix it but it's only that findHDF5 don't do its job well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #241