Dont rely on exception in node.exist #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdonline
force-pushed
the
improv/exist_simplify
branch
from
b285ef5
to
1f89c82
Compare
alexsavulescu
previously approved these changes
Mar 4, 2020
alexsavulescu
previously approved these changes
Mar 4, 2020
|
@alexsavulescu sorry, github always dimisses even on small changes. I dont intend to change more |
alexsavulescu
approved these changes
Mar 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
Node.exist()required catching an exception that we generated ourselves. Despite being a simple principle, it kind of used exceptions for flow control and In some compiler toolchains (QT) this would create unwanted error messages (#224, #289)This PR
Makes the low-level
_existfunction conditionally treat the error as a normal false, not throwing exception. This design even simplified the implementation of the publicexist()method.Fixes #289