Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify interface of H5Attribute with H5Slice_traits #378

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Unify interface of H5Attribute with H5Slice_traits #378

merged 2 commits into from
Oct 12, 2020

Conversation

alkino
Copy link
Member

@alkino alkino commented Oct 5, 2020

No description provided.

@alkino alkino requested a review from ferdonline October 5, 2020 17:41
matz-e
matz-e reviewed Oct 6, 2020
View reviewed changes
Copy link
Member

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So no data conversion for raw operations?

@alkino
Copy link
Member Author

alkino commented Oct 6, 2020 •
edited

So no data conversion for raw operations?

What do you mean, it's here only for read_raw (called read(T*)) and write_raw.

@ferdonline
Copy link
Contributor

ferdonline commented Oct 12, 2020 •
edited

This kinda addresses #285, right? they use the same API, although they don't share code (yet!) :)
Maybe we can have a follow up PR to deduplicate a bit?

@alkino
Copy link
Member Author

alkino commented Oct 12, 2020

This patch was extracted from #366 to simplify it.

The next patch is #366 and deduplicate most things.

@alkino alkino merged commit a9ca7dc into master Oct 12, 2020
@alkino alkino deleted the fix_attributes branch October 12, 2020 16:26
@alkino alkino mentioned this pull request Feb 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz-e matz-e matz-e left review comments

@ferdonline ferdonline ferdonline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alkino @ferdonline @matz-e