Adding CMake include guard #389
Conversation
| @@ -1,79 +1,82 @@ | |||
| # Link against target system libs | |||
| # ------------------------------- | |||
|
|
|||
| # Independent target to make it possible to have new dependencies each build | |||
| add_library(libdeps INTERFACE) | |||
| if(NOT TARGET libdeps) | |||
There was a problem hiding this comment.
This makes me wonder… if I declare my own target libdeps (the name seems pretty generic), and then include HighFive, wouldn't this lead to collision / failure, too?
There was a problem hiding this comment.
Sure. This is the reason I have always been favour of having a makeshift namespace. Firstly, one should:
libdeps->HighFive::dependecies
Secondly, one could allow a finer precision:HighFive::hdf5HighFive::use_EigenHighFive::use_xtensorHighFive::use_Boost
There was a problem hiding this comment.
That seems reasonable to me… also found this:
https://cmake.org/cmake/help/v3.10/command/include_guard.html?highlight=include_guard
unfortunately pretty late, only in 3.10 onwards.
There was a problem hiding this comment.
include_guard seem nice. Just as good as the if though. Let me switch to HighFive::dependencies here, and then to the more refined things in separate PR.
There was a problem hiding this comment.
That change is going to take a bit more work than I hoped. Personally I find HighFive's CMake support a bit too involved... Anyway, let's do the bugfix now and improvement separately.
|
Ping @matz-e @alkino @ferdonline |
Fixes #387