Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing GitHub Actions CI #416

Merged
merged 3 commits into from
Mar 10, 2021
Merged

Introducing GitHub Actions CI #416

merged 3 commits into from
Mar 10, 2021

Conversation

ferdonline
Copy link
Contributor

@ferdonline ferdonline commented Mar 8, 2021

Description

This PR introduces GitHub actions-based CI

The strategy is to test for several Linux (Ubuntu) systems, for several compilers, Mac and Windows
Total: 10 jobs

Combinations

Linux_MPI:
    os: [ubuntu-16.04, ubuntu-18.04, ubuntu-20.04]
    compiler: (default/old)
    options: PARALLEL_HDF5 + XTENSOR + EIGEN

Linux_Compilers:
    runs-on: ubuntu-18.04
    compilers: [clang-8, clang-9, gcc-8, gcc-9,  gcc-10]
    options: EIGEN

MacOS: (default compiler + EIGEN)

Windows: (Default compiler + EIGEN + Xtensor)

Fixes #402

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
push:
branches:
- live-debug*
- ci_test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ci_test
- master

Copy link
Contributor Author

@ferdonline ferdonline Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is a good idea to leave master out, since push to master is only allowed with PRs, which are already tested.
having a special ci_test is debatable, the idea is to have a special branch so that we run CI every time we push, which is useful mostly to develop the CI itself. Do you suggest another way? @alexsavulescu

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it's standard practice to run CI against master. It's true it would virtually be redundant wrt PRs, regardless of merge strategy. Additional steps can be done if isMaster() like storing artifacts, publishing documentation, displaying CI badges and so on. I guess we can look at it also as a sanity check.

having a special ci_test is debatable, the idea is to have a special branch so that we run CI every time we push, which is useful mostly to develop the CI itself. Do you suggest another way? @alexsavulescu

The CI will run for each PR every time a new commit is pushed even when working on the CI, so there is no need for a special branch. To work on the CI itself, the most straightforward (and isolated way) is to use a fork, where you can modify master directly or even use PRs (if you don't want to add master branch on push).

Copy link
Contributor

@alexsavulescu alexsavulescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ferdonline ferdonline merged commit ebe894a into master Mar 10, 2021
@ferdonline ferdonline deleted the gh_actions branch March 10, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to Github Actions
2 participants