-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing GitHub Actions CI #416
Conversation
push: | ||
branches: | ||
- live-debug* | ||
- ci_test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ci_test | |
- master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a good idea to leave master out, since push to master is only allowed with PRs, which are already tested.
having a special ci_test
is debatable, the idea is to have a special branch so that we run CI every time we push, which is useful mostly to develop the CI itself. Do you suggest another way? @alexsavulescu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say it's standard practice to run CI against master
. It's true it would virtually be redundant wrt PRs, regardless of merge strategy. Additional steps can be done if isMaster()
like storing artifacts, publishing documentation, displaying CI badges and so on. I guess we can look at it also as a sanity check.
having a special
ci_test
is debatable, the idea is to have a special branch so that we run CI every time we push, which is useful mostly to develop the CI itself. Do you suggest another way? @alexsavulescu
The CI will run for each PR every time a new commit is pushed even when working on the CI, so there is no need for a special branch. To work on the CI itself, the most straightforward (and isolated way) is to use a fork, where you can modify master
directly or even use PRs (if you don't want to add master
branch on push).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR introduces GitHub actions-based CI
The strategy is to test for several Linux (Ubuntu) systems, for several compilers, Mac and Windows
Total: 10 jobs
Combinations
Fixes #402