Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option *parents* to createDataSet #425

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Add option *parents* to createDataSet #425

merged 3 commits into from
Mar 31, 2021

Conversation

alkino
Copy link
Member

@alkino alkino commented Mar 30, 2021

This way the parents group can be created automatically if they don't exist.

Deprecate the function createGroupsToDataSet inside the easy part and stop using it internally

@alkino
Add option *parents* to createDataSet
81919bd 
This way the parents group can be created automatically if they don't exist.

Deprecate the function *createGroupsToDataSet* inside the easy part and stop using it internally
@tdegeus
Copy link
Collaborator

tdegeus commented Mar 31, 2021

Amazing !

Since createGroupsToDataSet was in the detail namespace I would say that it could be removed immediately. Alternatively it can be kept for a while but with a compiler warning using [[ deprecated ]]

@alkino
Copy link
Member Author

alkino commented Mar 31, 2021

Amazing !

Since createGroupsToDataSet was in the detail namespace I would say that it could be removed immediately. Alternatively it can be kept for a while but with a compiler warning using [[ deprecated ]]

Don't ask me twice to delete dead code!

@tdegeus
Copy link
Collaborator

tdegeus commented Mar 31, 2021

Don't ask me twice to delete dead code!

In that case... I think that with this change getParentName can go too. It was only used by createGroupsToDataSet and also in the detail namespace. So unless that is a which for it to be part of the public API I think that it can be removed!

@alkino alkino merged commit 17bffb2 into master Mar 31, 2021
@alkino alkino deleted the add_parents_inside_create_dataset branch March 31, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferdonline ferdonline ferdonline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alkino @tdegeus @ferdonline