Unified reading/writing attributes and datasets #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdonline
changed the title
ferdonline
changed the title
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
=========================================
Coverage ? 78.53%
=========================================
Files ? 61
Lines ? 3145
Branches ? 0
=========================================
Hits ? 2470
Misses ? 675
Partials ? 0 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reading attributes now uses the same routines as reading datasets.
Besides the smaller code due to reuse, now it support fixed-length
strings
Fixes #322 and #285
How to test this?
Tests were added to
tests_high_five_base.cppinHighFiveFixedLenStringArrayAttribute