bugfix: always refer to the proper signed type for signed char
#518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous usage of H5T_NATIVE_CHAR for `signed char` fails on Fedora/aarch64. Needed for BlueBrain/libsonata#184.
pramodk
approved these changes
Mar 17, 2022
alkino
added a commit
that referenced
this pull request
Apr 5, 2022
Version 2.4.0 - 2022-04-05 New Features: - Construct a compound type from an already existing hid (#469). Thanks to Maximilian Nöthe. - Add support for long double (#494) - Add support for H5Pset_libver_bounds and H5Pset_meta_block_size support (#500) - New interface to select complex hyperslabs, irregular hyperslabs are limited to/from 1D array (#538 and #545) Improvements: - Use inline where it is needed, otherwise some code can lead to "multiple definition" (#516). Thanks to Chris Byrohl. - Use Catch2 inside of boost for tests, this way there is less dependencies (#521) - CI now run with more external librairies (boost, eige, xtensor, xtl) (#536) Bug Fixes: - Better support of const types (#460). Thanks to Philip Deegan. - Vector of size zero was previously lead to UB (#502). Thanks to Haoran Ni. - Use H5T_NATIVE_SCHAR instead of H5T_NATIVE_CHAR for "signed char" (#518)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous usage of H5T_NATIVE_CHAR for
signed charfails onFedora/aarch64. Needed for BlueBrain/libsonata#184.