Implement file space strategies. #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkino
reviewed
Oct 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
=========================================
Coverage ? 79.19%
=========================================
Files ? 65
Lines ? 3609
Branches ? 0
=========================================
Hits ? 2858
Misses ? 751
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
One thing to consider is if we want to start adding more and more methods to |
matz-e
reviewed
Oct 17, 2022
matz-e
previously approved these changes
Oct 17, 2022
1uc
force-pushed
the
add-paged-allocation
branch
from
6305ea4
to
cf7d989
Compare
1uc
force-pushed
the
add-paged-allocation
branch
from
df0b9c6
to
56aeb20
Compare
matz-e
reviewed
Nov 2, 2022
Co-authored-by: Matthias Wolf <matthias.wolf@epfl.ch>
matz-e
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for the different file space strategies:
https://portal.hdfgroup.org/display/HDF5/H5P_SET_FILE_SPACE_STRATEGY
https://portal.hdfgroup.org/display/HDF5/H5P_SET_FILE_SPACE_PAGE_SIZE
including paged allocation with configurable page size. Since both are "file creation properties". This MR also includes a new ctor for
Filewhich enables creating files specifying both creation and access properties.