New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collective metadata #624
Collective metadata #624
Conversation
I think it would be nice to have an example showing how to set everything up to use collectives, always. However this requires both this PR and #623. Therefore, we'll do this later. |
void MPIOCollectiveMetadata::apply(const hid_t plist) const { | ||
auto read = MPIOCollectiveMetadataRead{collective_}; | ||
auto write = MPIOCollectiveMetadataWrite{collective_}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sigh... there are probably some users out there somewhere that want collective write but independent read, or vice versa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which case, with property list plist
, they would ask for collective reading:
plist.add(MPIOCollectiveMetadataRead{});
or collective writing:
plist.add(MPIOCollectiveMetadataWrite{});
The third option MPIOCollectiveMetadata
reduces the typing effort and increases discoverability of the correct settings for the case where all operations are collective.
e7738a4
to
f589b35
Compare
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
=========================================
Coverage ? 79.33%
=========================================
Files ? 64
Lines ? 3533
Branches ? 0
=========================================
Hits ? 2803
Misses ? 730
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This PR enables users to configure collective metadata reads and writes (at file level). The heavy lifting was done in #620; here we simply restructure the proposed solution.
In more detail, this PR adds:
MPIOFileDriver
.