Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to get property list from object #629

Merged
merged 11 commits into from Nov 3, 2022

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 2, 2022

Usage

#include <highfive/H5File.hpp>

using namespace HighFive;

int main() {
    File file{"a.h5"};
    auto fapl = file.getAccessPropertyList();
    return 0;
}

matz-e
matz-e previously approved these changes Nov 2, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@805f0e1). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #629   +/-   ##
=========================================
  Coverage          ?   79.29%           
=========================================
  Files             ?       65           
  Lines             ?     3623           
  Branches          ?        0           
=========================================
  Hits              ?     2873           
  Misses            ?      750           
  Partials          ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

1uc
1uc previously approved these changes Nov 2, 2022
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is very useful.

matz-e
matz-e previously approved these changes Nov 2, 2022
Copy link
Member

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Property is dropped from the method names, as in getCreatePropertyList would be a wee bit cleaner. But I'm fine with how it is.

@alkino alkino dismissed stale reviews from matz-e and 1uc via 47f5ee4 November 2, 2022 16:31
1uc
1uc previously approved these changes Nov 2, 2022
@alkino alkino merged commit 1cf20ee into master Nov 3, 2022
@alkino alkino deleted the cornu/get_plist_from_obj branch November 3, 2022 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants